Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix idle duration timeout for pod/node batcher #1244

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jonathan-innis
Copy link
Member

@jonathan-innis jonathan-innis commented May 10, 2024

Fixes #1173

TODO: Waiting on testing to be implemented

Description

How was this change tested?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 10, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jonathan-innis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 10, 2024
@jonathan-innis jonathan-innis force-pushed the fix-idle-duration-timeout branch 2 times, most recently from 62dc217 to 8365106 Compare May 10, 2024 18:19
@coveralls
Copy link

coveralls commented May 10, 2024

Pull Request Test Coverage Report for Build 10590799364

Details

  • 7 of 36 (19.44%) changed or added relevant lines in 4 files are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.06%) to 78.157%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/controllers/controllers.go 0 1 0.0%
pkg/controllers/provisioning/controller.go 0 2 0.0%
pkg/controllers/provisioning/provisioner.go 2 4 50.0%
pkg/controllers/provisioning/batcher.go 5 29 17.24%
Files with Coverage Reduction New Missed Lines %
pkg/controllers/provisioning/provisioner.go 1 78.8%
pkg/controllers/provisioning/scheduling/nodeclaim.go 2 89.13%
Totals Coverage Status
Change from base Build 10588795133: -0.06%
Covered Lines: 8627
Relevant Lines: 11038

💛 - Coveralls

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 15, 2024
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 16, 2024
Copy link

github-actions bot commented Jun 2, 2024

This PR has been inactive for 14 days. StaleBot will close this stale PR after 14 more days of inactivity.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 2, 2024
@jonathan-innis jonathan-innis added needs-review PRs that are still going through the review process and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jun 3, 2024
@jonathan-innis
Copy link
Member Author

/assign jigisha620

@k8s-ci-robot
Copy link
Contributor

@jonathan-innis: GitHub didn't allow me to assign the following users: jigisha620.

Note that only kubernetes-sigs members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign jigisha620

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jonathan-innis jonathan-innis force-pushed the fix-idle-duration-timeout branch 3 times, most recently from 2e30a05 to 9654afd Compare July 10, 2024 08:04
@jonathan-innis jonathan-innis force-pushed the fix-idle-duration-timeout branch 2 times, most recently from dd0109f to 40ab1d2 Compare July 30, 2024 06:18
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 13, 2024
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. needs-review PRs that are still going through the review process size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The batchIdleDuration value is ignored
3 participants