[WIP] feat: Drop disruption reason and support dirft sub-reason for budgets

[engedaam]

Fixes #N/A

Description

How was this change tested?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[k8s-ci-robot]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: engedaam
Once this PR has been reviewed and has the lgtm label, please assign bwagner5 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jonathan-innis]

I posted my thoughts in the K8s slack but I had a few high-level concerns with this approach:

1. What does it look like when you intersect the top-level Drifted condition with sub-conditions? I'm assuming that the most restrictive one applies but just want to confirm
2. The current model only allows a single condition at a given time which means that the ownership for the condition as well as the relative ordering of conditions gets a little ambiguous. If I have a NodeClaim that has both Subnets drifted and AMIs drifted and I have a budget that is more restrictive on AMIs, I would expect the AMI budget to apply, but today if the subnet condition came first in the checks, we would ignore the more restrictive budget. How are we thinking about filling the gap on this issue?

[k8s-ci-robot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[github-actions]

This PR has been inactive for 14 days. StaleBot will close this stale PR after 14 more days of inactivity.