Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#38488): check source_code integrity during source_item mass save #3411

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

theuargb
Copy link

@theuargb theuargb commented Jul 18, 2024

Description (*)

This fixes the mentioned issue by implementing a fast integrity check for the source code while saving multiple source items, including mixed-case scenarios.

The proposed solution feels in line with the original feature implementation, giving almost no overhead (1 [indexed] SQL query).

Fixed Issues (if relevant)

  1. Fixes magento/magento#38488: Inventory source item's source_code is case insensitive during insert, but case sensitive during read

Manual testing scenarios (*)

  1. Create at least one additional custom stock source
  2. Create a new stock associated with the website
  3. Associate the custom sources to the new stock
  4. Utilizing the API, create an inventory source item providing incorrect source code (eg. warehouse_alpha -> waRehOuse_alPha)
  5. With this fix, an error will be logged and returned - no incorrect source items will be saved to break the admin panel

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@theuargb
Copy link
Author

@magento give me 2.4-develop instance

Copy link

Hi @theuargb. Thank you for your request. I'm working on Magento instance for you.

Copy link

Hi @theuargb, unfortunately there is no ability to deploy Magento instance at the moment. Please try again later.

@theuargb theuargb marked this pull request as ready for review July 20, 2024 21:02
@theuargb
Copy link
Author

@magento give me 2.4-develop instance

Copy link

Hi @theuargb. Thank you for your request. I'm working on Magento instance for you.

Copy link

Hi @theuargb, unfortunately there is no ability to deploy Magento instance at the moment. Please try again later.

@theuargb
Copy link
Author

theuargb commented Aug 1, 2024

@magento give me 2.4-develop instance

Copy link

Hi @theuargb. Thank you for your request. I'm working on Magento instance for you.

Copy link

Hi @theuargb, unfortunately there is no ability to deploy Magento instance at the moment. Please try again later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Ready for Review
Development

Successfully merging this pull request may close these issues.

2 participants