Feature/send chatstates #97
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 23, 2013 19:08
|
Not sure where the comments went but ChatSwitchedTo/From needs to be merged and moved to ChatViewManagerBase.set_ActiveChat |
|
|
||
| public void SetChatState(ChatState type) | ||
| { | ||
| if (Frontend.EngineVersion < new Version(0, 9, 1)) { |
There was a problem hiding this comment.
The next feature release that could contain this feature is 0.10, thus this should be < 0, 10 (0.9.1 will be a bugfix release from the stable branch)
|
Even though the XMPP support is fading away with declined XMPP adaption, sending the chat states and also the Frontend library changes are very useful to integrate, thus I am re-opening this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this needs to be applied after the chatviewmanager refactoring :)