-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: fixed leak #3298
base: main
Are you sure you want to change the base?
feat: fixed leak #3298
Conversation
@microsoft-github-policy-service agree |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi @vcharmcaster, I'd suggest reverting the try-with-resources around the (mock) exporters, since those are known to not require closing, and avoids additional indentation.
then will review the remaining, thx!
updated |
Fix # leaks in unit test
For significant contributions please make sure you have completed the following items: