Fix GetTableUrl for DataPerCompany=false #2303
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
AL: System Application
From Fork
JesperSchulz
added
Integration
JesperSchulz
approved these changes
Nov 15, 2024
nikolakukrika
requested changes
Nov 15, 2024
| begin | ||
| if Company = '' then | ||
| TableMetadata.Get(TableNo); | ||
| if not TableMetadata.DataPerCompany then |
There was a problem hiding this comment.
What if Company is blank and the data is per company? Why cannot we always replace the blank company name with the current company?
This will also slow down the code since we will load the table metadata, which can be slow on the first call. I'm not sure how slow it is after the first call.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix GetTableUrl for Tables with
DataPerCompany=falseWork Item(s)
Fixes #2262
Fixes AB#557526