-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New System App Module for easy file systems access #663
base: main
Are you sure you want to change the base?
Conversation
Could not find linked issues in the pull request description. Please make sure the pull request description contains a line that contains 'Fixes #' followed by the issue number being fixed. Use that pattern for every issue you want to link. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR needs some work before the real code review can conducted.
src/System Application/App/File System/permissions/FileSystemAdmin.PermissionSet.al
Outdated
Show resolved
Hide resolved
src/System Application/App/File System/permissions/FileSystemEdit.PermissionSet.al
Outdated
Show resolved
Hide resolved
src/System Application/App/File System/permissions/FileSystemEdit.PermissionSet.al
Outdated
Show resolved
Hide resolved
src/System Application/App/File System/permissions/FileSystemObjects.PermissionSetExt.al
Outdated
Show resolved
Hide resolved
src/System Application/App/File System/permissions/FileSystemObjects.PermissionSetExt.al
Outdated
Show resolved
Hide resolved
src/System Application/App/File System/src/Account/FileAccountImpl.Codeunit.al
Outdated
Show resolved
Hide resolved
src/System Application/App/File System/src/Account/FileAccountImpl.Codeunit.al
Outdated
Show resolved
Hide resolved
src/System Application/App/File System/src/Account/FileAccountImpl.Codeunit.al
Outdated
Show resolved
Hide resolved
src/System Application/App/File System/src/Account/FileAccountImpl.Codeunit.al
Outdated
Show resolved
Hide resolved
src/System Application/App/File System/src/Account/FileAccountImpl.Codeunit.al
Show resolved
Hide resolved
src/System Application/App/File System/src/Account/FileAccountImpl.Codeunit.al
Outdated
Show resolved
Hide resolved
src/System Application/App/File System/src/FileSystem/FileSystemImp.Codeunit.al
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Try to enable the codecops. You've got a few issues to address to satisfy the rules.
I'll progress to the functional review now.
src/System Application/App/File System/src/Account/FileAccounts.Page.al
Outdated
Show resolved
Hide resolved
src/System Application/App/File System/src/Account/FileAccounts.Page.al
Outdated
Show resolved
Hide resolved
DataClassification = SystemMetadata; | ||
} | ||
|
||
field(6; LogoBlob; Blob) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We cannot use Blobs of subtype bitmap anymore. We should use Media instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Solved.
src/System Application/App/File System/permissions/FileSystemEdit.PermissionSet.al
Outdated
Show resolved
Hide resolved
src/System Application/App/File System/permissions/FileSystemRead.PermissionSet.al
Outdated
Show resolved
Hide resolved
src/System Application/App/File System/src/FileSystem/FileSystemImp.Codeunit.al
Outdated
Show resolved
Hide resolved
src/System Application/App/File System/src/Account/FileAccountWizard.Page.al
Outdated
Show resolved
Hide resolved
src/System Application/App/File System/src/FileSystem/FileSystemImp.Codeunit.al
Outdated
Show resolved
Hide resolved
src/System Application/App/File System/src/Lookup/FileAccountBrowserMgt.Codeunit.al
Outdated
Show resolved
Hide resolved
src/System Application/App/File System/src/Lookup/FileAccountBrowserMgt.Codeunit.al
Outdated
Show resolved
Hide resolved
src/System Application/App/File System/src/Account/FileAccountWizard.Page.al
Outdated
Show resolved
Hide resolved
src/System Application/App/File System/src/Account/FileAccountWizard.Page.al
Outdated
Show resolved
Hide resolved
src/System Application/App/File System/src/Account/FileAccountImpl.Codeunit.al
Outdated
Show resolved
Hide resolved
src/System Application/App/File System/src/Account/FileAccountImpl.Codeunit.al
Outdated
Show resolved
Hide resolved
src/System Application/Test Library/File System/src/Mock/FileAccountsSelectionMock.Codeunit.al
Outdated
Show resolved
Hide resolved
Alright, let's run the CI once more and see where we land. Would be real good to get this one processed this week. |
@IceOnly, could you look at the build failures, while I test your feature? Seem to be easy CodeCop issues. We need a successful build, before we can push this forward. |
@JesperSchulz done! |
If we are to accept this module, we want to have some uptake of it in the Base Application. We're currently looking into possible scenarios! Background: ideally, we no longer want to have modules without any uptake - for 2 reasons:
Work is in progress! |
@IceOnly, those were the wrong app.jsons 😉 You should pull main into your branch, and then you should update your app.jsons to the latest version. Then I hope your code compiles and all tests pass, and if they do, we can merge. |
@JesperSchulz should be correct now 🙈 |
Migration of microsoft/ALAppExtensions#23225
Now that we have made several clients Universal code ready.
One of the main problems turned out to be the replacement of the file record and the file object (File.Create, File.Exists).
Some of our customers now use Azure Blob Service from the System app. Others don't have a good internet and now use a local microservice with REST API, others use Azure File Shares.
The problem is that every integration is different. I think many other partners will have the same problem.
To simplify access I have adopted the email module and created new file accounts.
With just one codeunit, a developer can now connect to various file services without having to know how they actually work. The code unit "File System" delviers everything taht is needed.
An additional PR contains three connector apps:
microsoft/ALAppExtensions#23225
This Apps will conenct:
All three service can be access over one unified interface!
New provider in the future could be:
An example that shows how simple it is to use the new modules can be found here:
https://github.com/IceOnly/BC_FileSystem_Example
But before I go round the whole thing, I'm interested in whether there is any interest in the module at all.
Here are some Screenshots:
I have decided in favour of some restrictions. Paths must not start with a /. The only supported path separator is /. If services that require a \ are to be connected, this must be translated by the connector app.
These restrictions should ensure that the file service can be exchanged without upgrading data.