Save output model to output_dir #1430
Conversation
| @@ -422,3 +429,30 @@ def _plot_pareto_frontier(self, ranks=None, save_path=None, is_show=True, save_f | |||
|
|
|||
| if is_show: | |||
| fig.show() | |||
|
|
|||
|
|
|||
| def get_best_candidate_node( | |||
There was a problem hiding this comment.
could you add some comments here to explain the logic?
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
test/unit_test/cli/test_cli.py
Outdated
| @@ -284,7 +282,7 @@ def test_quantize_command(mock_repo_exists, mock_tempdir, mock_run, algorithm_na | |||
| mock_tempdir.return_value = tmpdir.resolve() | |||
| mock_run.return_value = {} | |||
|
|
|||
| workflow_output_dir = tmpdir / "output_model" / algorithm_name | |||
| workflow_output_dir = tmpdir / algorithm_name | |||
There was a problem hiding this comment.
I don't think the algorithm name exists anymore? This was for the behavior where each pass flow saved it's own output model
There was a problem hiding this comment.
@xiaoyu-work please take a look at this too
There was a problem hiding this comment.
Good call. That's correct. Updated.
| @@ -422,9 +429,6 @@ def run_no_search( | |||
| json.dump(signal.to_json(), f, indent=4) | |||
| logger.info("Saved evaluation results of output model to %s", results_path) | |||
|
|
|||
| self.cache.save_model(model_id=model_ids[-1], output_dir=flow_output_dir, overwrite=True) | |||
There was a problem hiding this comment.
is this is not present, then I don't think this pass_flow nesting is present?
not sure if we should keep it or not
There was a problem hiding this comment.
See my previous, removing this means it does not save pass_flow models to this path, but we still have results_path = flow_output_dir / "metrics.json" in this path. My expectation is we could remove pass_flow path also.
Describe your changes
Save output model to output_dir
Checklist before requesting a review
lintrunner -a(Optional) Issue link