HfModelHandler: Call save_metadata
after model is saved
#1485
+124
−50
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
save_pretrained
on the modified PreTrained model object. This was done so thatsave_metadata
doesn't override any files saved bysave_pretrained
.trust_remote_code=True
since it also tries to save the module files.save_metadata
aftersave_pretrained
in `save_model_files. This is made possible with the following changes:test_hf_model
is more comprehensive now with both local and hf-hub models.Checklist before requesting a review
lintrunner -a
(Optional) Issue link
Fixes #1442