New document theme! #1491
Open
New document theme! #1491
+2,674
−2,575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…om/microsoft/Olive into samuel100/docs-quickstart-overhaul
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
lintrunner found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
docs/source/how-to/configure-workflows/model-opt-and-transform/index.rst
Fixed
Show fixed
Hide fixed
jambayk
reviewed
Nov 15, 2024
jambayk
reviewed
Nov 16, 2024
| @@ -17,7 +17,7 @@ jobs: | |||
| steps: | |||
| - template: olive-setup-template.yaml | |||
| parameters: | |||
| python_version: '3.8' | |||
| python_version: '3.10' | |||
There was a problem hiding this comment.
do the new dependencies require python 3.10? When i tried moving the doc build over to python 3.8, there was an issue with one of the dependencies. it's the same error in the failed doc build ci here
There was a problem hiding this comment.
Yeah i just realized this change is causing an error. I just want to try if it's possible to upgrade the python version. I reverted this change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Checklist before requesting a review
lintrunner -a(Optional) Issue link