Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce pnpm lockfile v9 detector #1283

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Introduce pnpm lockfile v9 detector #1283

wants to merge 7 commits into from

Conversation

FernandoRojo
Copy link
Contributor

@FernandoRojo FernandoRojo commented Oct 24, 2024 •
edited
Loading

There is still no official docs for the new v9 lock if format, so this parsing logic is empirically based and will be updated as specs are released
Issue tracking v9 specs: pnpm/spec#6
Format should eventually get updated here: https://github.com/pnpm/spec/blob/master/lockfile

Includes a small refactoring to re-use code and establish consistency between lockfile parsing.

@FernandoRojo FernandoRojo requested a review from a team as a code owner October 24, 2024 04:28
@codecov Codecov
Copy link

codecov bot commented Oct 24, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 95.75597% with 16 lines in your changes missing coverage. Please review.

Project coverage is 89.1%. Comparing base (179e5c0) to head (422e372).

Files with missing lines Patch % Lines
...rs/pnpm/ParsingUtilities/PnpmV5ParsingUtilities.cs 82.7% 3 Missing and 2 partials ⚠️
...rs/pnpm/ParsingUtilities/PnpmV6ParsingUtilities.cs 72.7% 2 Missing and 1 partial ⚠️
...ComponentDetection.Detectors/pnpm/Pnpm6Detector.cs 66.6% 1 Missing and 2 partials ⚠️
...pm/ParsingUtilities/PnpmParsingUtilitiesFactory.cs 86.6% 1 Missing and 1 partial ⚠️
.../pnpm/ParsingUtilities/PnpmParsingUtilitiesBase.cs 95.0% 0 Missing and 1 partial ⚠️
...ComponentDetection.Detectors/pnpm/Pnpm5Detector.cs 90.9% 0 Missing and 1 partial ⚠️
...ComponentDetection.Detectors/pnpm/Pnpm9Detector.cs 97.8% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@          Coverage Diff           @@
##            main   #1283    +/-   ##
======================================
  Coverage   89.1%   89.1%            
======================================
  Files        361     369     +8     
  Lines      27742   27996   +254     
  Branches    1757    1780    +23     
======================================
+ Hits       24719   24972   +253     
- Misses      2643    2644     +1     
  Partials     380     380

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@grvillic grvillic linked an issue Oct 24, 2024 that may be closed by this pull request
Support pnpm 9 #1148
Open
@grvillic grvillic self-requested a review October 25, 2024 15:10
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 28, 2024 •
edited
Loading

👋 Hi! It looks like you modified some files in the Detectors folder.
You may need to bump the detector versions if any of the following scenarios apply:

  • The detector detects more or fewer components than before
  • The detector generates different parent/child graph relationships than before
  • The detector generates different devDependencies values than before

If none of the above scenarios apply, feel free to ignore this comment 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grvillic grvillic grvillic approved these changes

@chsalgado chsalgado Awaiting requested review from chsalgado chsalgado is a code owner automatically assigned from microsoft/ose-component-detection-maintainers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support pnpm 9
2 participants
@FernandoRojo @grvillic