Fix detector component filepath custom overrides #1306
+74
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
A detector does not need to specify location where a component was found. Nevertheless, custom wrapper plugins can report additional locations if desired and that shouldn't be blocked.
In PR #648 a regression occurred while trying to address an experiments framework bug. We don't want to unsuspectingly record locations for experimental detectors before producing the final graph. We added a check to prevent experiments from overriding the graph, but this was partially incomplete, because we are clearing the file paths at the top of the method.
Solution
Use the same flag to verify if the component file paths should be updated and only clear the list when generating final graph.