Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[runtime] Enhancement: Use runtime instead of libos #1058

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

iyzhang
Copy link
Contributor

@iyzhang iyzhang commented Dec 8, 2023

This PR removes the following functions from the libOSes and directly calls the runtime:

  • poll
  • schedule/from_task_id
  • pack_result
  • sgaalloc
  • sgafree

Note that we have not moved the sgaalloc and free functions for the libOSes that need special memory. I have filed an issue for that: #1057

@iyzhang iyzhang force-pushed the enhancement-runttime-remove-dup-code branch from 1d1ae48 to b5c027d Compare December 8, 2023 20:37
@ppenna ppenna force-pushed the enhancement-runttime-remove-dup-code branch from b5c027d to 488aff0 Compare December 11, 2023 15:46
src/rust/catmem/mod.rs Outdated Show resolved Hide resolved
@ppenna ppenna force-pushed the enhancement-runttime-remove-dup-code branch from 488aff0 to ca86ffd Compare December 11, 2023 16:04
Copy link
Collaborator

@ppenna ppenna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ppenna ppenna self-assigned this Dec 11, 2023
@ppenna ppenna added the enhancement Enhancement Request on an Existing Feature label Dec 11, 2023
@ppenna ppenna merged commit b28b068 into dev Dec 11, 2023
15 checks passed
@ppenna ppenna deleted the enhancement-runttime-remove-dup-code branch December 11, 2023 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement Request on an Existing Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants