feat(react-swatch-picker): Correctly integrating SwatchPicker with Field component
#33274
+15
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Bundle size report
Unchanged fixtures
|
|
Pull request demo site: URL |
fabricteam
reviewed
Nov 14, 2024
| @@ -0,0 +1,7 @@ | |||
| { | |||
There was a problem hiding this comment.
🕵🏾♀️ visual regressions to review in the fluentuiv9 Visual Regression Report
Avatar Converged 3 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Avatar Converged.Badge Mask RTL.chromium.png | 44 | Changed |
| Avatar Converged.size+image+badge.chromium.png | 1 | Changed |
| Avatar Converged.badgeMask.chromium.png | 1 | Changed |
Drawer 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Drawer.Full Overlay High Contrast.chromium.png | 4933 | Changed |
| Drawer.Full Overlay Dark Mode.chromium.png | 2549 | Changed |
ValentinaKozlova
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
SwatchPickerhad no integration with theFieldcomponent. So when they were used together, all the expectations of correctly labeling things for accessibility were not being meant.New Behavior
We have integrated the
Field's context withSwatchPickerso that when they are used together,SwatchPickerwill be correctly labelled for accessibility.Related Issue(s)