Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Preparing to use 'dist' for more releases. #608

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: Preparing to use 'dist' for more releases. #608

wants to merge 1 commit into from

Conversation

alilleybrinker
Copy link
Collaborator

This relies on the upgrade to the latest version of 'dist'. Since we now have plugins that we want to produce pre-built binaries for, this updates our build configuration to support that. It'll need to be tested.

@alilleybrinker alilleybrinker force-pushed the alilleybrinker/prep-dist branch 2 times, most recently from 8be06d2 to d42a187 Compare November 9, 2024 00:01
@alilleybrinker
Copy link
Collaborator Author

Update: The dist folks are investigating this error; trying to figure out why plan is complaining, which it shouldn't be doing.

@alilleybrinker
Copy link
Collaborator Author

After some debugging, I was able to at least eliminate the duplication of packages found by cargo-dist. Turns out my workspace.members field in the dist-workspace.toml file was wrong; when including a Cargo virtual workspace with many distable packages in it, you only need to include the root, not each package individually.

@alilleybrinker alilleybrinker force-pushed the alilleybrinker/prep-dist branch 2 times, most recently from f8318a3 to 844f673 Compare November 13, 2024 19:34
@alilleybrinker
chore: Preparing to use 'dist' for more releases.
9887e88 
This relies on the upgrade to the latest version of 'dist'. Since
we now have plugins that we want to produce pre-built binaries for,
this updates our build configuration to support that. It'll need to
be tested.

Signed-off-by: Andrew Lilley Brinker <[email protected]>
@alilleybrinker
Copy link
Collaborator Author

Update: cargo-dist team is working on resolving the bug that's blocking this PR. Basically, an internal setting called needs_coherence is being incorrectly set to true for cargo dist plan. Once the fix is out I'll update this to use the patched version of cargo-dist and we can proceed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
Hipcheck Dev Roadmap
Status: Todo
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@alilleybrinker