Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggest filing a new bug when an external user comments on a closed bug #1669

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

suhaibmujahid
Copy link
Member

Resolves #1516

Checklist

  • Type annotations added to new functions
  • Docs added to functions touched in main classes
  • Dry-run produced the expected results
  • The to-be-announced tag added if this is worth announcing

@suhaibmujahid suhaibmujahid changed the title Suggest filing a new bug when an external user commenting on a closed bug Suggest filing a new bug when an external user comments on a closed bug Oct 7, 2022
@sylvestre
Copy link
Contributor

how often does this happen ? my gut feeling is that it is a bit overkill :) (but happy to be wrong)

@suhaibmujahid
Copy link
Member Author

suhaibmujahid commented Oct 7, 2022

how often does this happen?

39 bugs in the last 60 days.

Click to expand the list!
BugSummary
1792337 Nightly's About box is too wide
1792277 Sidebar doesn't correctly reflow when resized
1791090 [foxfooding] Desktop browser loads mobile site when using Tab pickup after browsing on phone
1790717 window.screenX doesn't work after bug 1749174
1789956 The contents of bookmarks folders within folders are moved to the left overtop of the folder menu and the folders' contents stopped being shown with Firefox Nightly 106.0a1 (2022-9-8) on Wayland
1789050 The Bookmarks menu flickered and bookmarks folders within a folder were moved to the right and down in Firefox Nightly 106.0a1 (2022-09-02)
1788684 Access to router.asus.com broken as of version 104
1787423 security.insecure_field_warning.contextual.enabled doesn't disable unsecure warning anymore
1787405 immediate expression requires a # prefix
1787361 Dragging scrollbar thumb not working with touchscreen or stylus
1786858 Permissions dialog for external application links has increased font-size
1786742 Firefox Snap does not read same configuration locations as binary version
1786702 urlbar command help button opens a 404
1786667 Missing chrome or resource URL: resource://gre/modules/UpdateListener.sys.mjs
1786638 Crash in [@ refRelationSetCB]
1786521 Fix AppearanceValueAffectsFrames.
1786392 Firefox snap Ubuntu 22.04.1 LTS handles /tmp reference incorrectly.
1785305 [resize-observer] When first observing an element with ResizeObserver, lastReportedSize should get initialized with a -1 x -1 size
1785303 contentDocument and getSVGDocument() are always null for <object> embedding SVG
1785107 Print adds many blank pages, cannot be reproduced with print simulation
1784983 Crash in [@ mozilla::net::UrlClassifierFeatureEmailTrackingDataCollection::ProcessChannel]
1784393 Video playback becomes corrupted
1784221 Firefox will not render the red background on a PDF sample
1783887 [Colorway Closet] Colorways modal is displayed minimized with unnecessary scrolling bar on macOS
1783784 [rust 1.63] error: expected one of `!` or `::`, found keyword `mod`
1783529 Windows 10 v103 Higher's accent color
1783460 [QuickActions] Please move quick actions to the last row at the bottom
1781613 [Regression] Firefox-103 UI fonts larger than defined in gtk settings.ini
1778450 Can't use "Shift+Tab" to cycle from tabs to last page element when scroll tab arrows are displayed and Firefox View is not before the tabs in the tabstrip
1771854 GPU process broke WebXR support
1771555 VAAPI Hardware video decoding not working at all on intel iHD
1770818 When opening a new window with a custom new window URL configured, the web content is initially focused rather than the address bar
1768632 EnumSet::kMaxBits won't initialize
1756089 The browser keeps popping up a notification that I have to log in to my home network.
1716961 Validation bubbles stop appearing after opening too fast
1700798 [sway] Menus and alt-text flicker
1696807 https://codepen.io/thebabydino/pen/GRjdEmb has parts of the star missing while rotating
1694993 noopener window.open() shouldn't inherit principal
1588081 Notarization blocks geckodriver from starting when downloaded via a web browser

my gut feeling is that it is a bit overkill :) (but happy to be wrong)

I agree with you. I'm not convinced about the results yet. Many of the cases are false positives (where having the comments is helpful). This is why I marked the PR as a draft.

We could go in one of two directions from here:

  • Keep things as is (drop this patch).
  • Reduce false positives (improve the filtering to catch "met too" cases that are posted on fixed bugs).

@suhaibmujahid
Copy link
Member Author

Based on the decision in the last meeting with @marco-c:

  • Exclude WONTFIX
  • For DUPLICATE, point to the original bug and, if the original is closed, suggest opening a new bug
  • For INCOMPLETE, maybe ping someone as there might be enough information to proceed now?

For the last point, we could just include them in the email without performing any action (i.e., not posting on the bug), so we can monitor such cases. I will mark them in red. If we see a pattern worth handling, we could take care of it later. @marco-c WDYT? If you agree, I will file a follow-up issue.

@suhaibmujahid
Copy link
Member Author

Dry-run

The following bugs have an external comment after being closed:

BugSummary
1777419 "Delete cookies and site data when Firefox is closed" checkbox gets disabled on startup
1679630 Random connection timeout on localhost with HTTPS Only mode enabled
613645 HSTS doesn't work for non-default ports
428565 Firefox 3.X delays/prevents machine sleep on Mac OS X
306987 -moz-appearance: menulist-button uses css styled dropdown on top of native widget
758 Highlighting text in the viewer causes the app to crash

@suhaibmujahid
Copy link
Member Author

I noticed that many of the comments are spam. It could be helpful to automaticly tag spam comments here before suggesting opening a new bug. @marco-c wdyt?

@suhaibmujahid
Copy link
Member Author

Dry-run

The following bug has an external comment after being closed:

BugSummary
724829 Clicking to close/collapse a folder in bookmarks sidebar works, but opens another node

@marco-c
Copy link
Contributor

marco-c commented Oct 16, 2022

I noticed that many of the comments are spam. It could be helpful to automaticly tag spam comments here before suggesting opening a new bug. @marco-c wdyt?

Oh yes, it would be painful otherwise...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Surface closed bugs in which users comment that they are still affected
3 participants