Add whiteboard flag to webcompat sightline bugs #2498
+141
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgraham
force-pushed
the
webcompat_sightline
branch
from
4f05ba2
to
96524e0
Compare
jgraham
changed the title
ksy36
approved these changes
Nov 5, 2024
jgraham
force-pushed
the
webcompat_sightline
branch
from
96524e0
to
8ab569c
Compare
jgraham
force-pushed
the
webcompat_sightline
branch
from
8ab569c
to
8f99de6
Compare
jgraham
force-pushed
the
webcompat_sightline
branch
from
8f99de6
to
6e290ed
Compare
This should be set on all bugs that are part of the webcompat metrics set, and by no bugs that aren't. This initial approach just gets all the bugs that are either in that set or have the whiteboard entry, and implements the logic to update them in the client. Given that we expect initially to have ~700 bugs in that set, this means we need to set the maximum number of bugs to update to something rather high.
jgraham
force-pushed
the
webcompat_sightline
branch
from
6e290ed
to
4cb9b8e
Compare
There was a problem hiding this comment.
Thank you! LGTM! I have only minor comments.
We need to add this new rule to the bot's wiki page before deploying the new rule.
Comment on lines
+39
to
+43
| elif self.WHITEBOARD_ENTRY in whiteboard: | ||
| self.autofix_changes[bug_id] = { | ||
| "whiteboard": whiteboard.replace(self.WHITEBOARD_ENTRY, "") | ||
| } | ||
| return bug |
There was a problem hiding this comment.
nit: this could improve the readability a bit.
Suggested change
| elif self.WHITEBOARD_ENTRY in whiteboard: | |
| self.autofix_changes[bug_id] = { | |
| "whiteboard": whiteboard.replace(self.WHITEBOARD_ENTRY, "") | |
| } | |
| return bug | |
| else: | |
| if self.WHITEBOARD_ENTRY in whiteboard: | |
| self.autofix_changes[bug_id] = { | |
| "whiteboard": whiteboard.replace(self.WHITEBOARD_ENTRY, "") | |
| } | |
| return bug |
| self.sightline_ids = set() | ||
|
|
||
| def description(self) -> str: | ||
| return "Web Compat site report in the sightline metric set" |
There was a problem hiding this comment.
The description will be used as the title of the email.
Suggested change
| return "Web Compat site report in the sightline metric set" | |
| return "Bugs with the [webcompat:sightline] whiteboard tag updated" |
| @@ -75,4 +75,7 @@ python -m bugbot.rules.duplicate_copy_metadata --production | |||
| # Add `webcompat:platform-bug` keyword to bugs without a platform keyword | |||
| python -m bugbot.rules.webcompat_platform_without_keyword --production | |||
|
|
|||
| # Add `[webcompat:sightline]` whiteboard entry to bugs in sightline metric set | |||
There was a problem hiding this comment.
We also remove it when it is applicable.
Suggested change
| # Add `[webcompat:sightline]` whiteboard entry to bugs in sightline metric set | |
| # Update `[webcompat:sightline]` whiteboard entry to bugs in sightline metric set |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
to-be-announcedtag added if this is worth announcing