Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove padend dependency #242

Closed
wants to merge 5 commits into from
Closed

remove padend dependency #242

wants to merge 5 commits into from

Conversation

Pomax
Copy link

@Pomax Pomax commented Sep 4, 2022

This replaces the use of the string.prototype.padend dependency with the normal String.padEnd function, removing the need for 3.3Mb of dependencies.

This PR fixes #241

This replaces the use of the string.prototype.padend dependency with the normal String.padEnd function, removing the need for 3.3Mb of dependencies.
Copy link

@zloirock zloirock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems also need to bump node in engines field to 8 and remove node less than 8 from .travis.yml.

@Pomax
Copy link
Author

Pomax commented Sep 4, 2022

good point, bumped up the engine requirement to the oldest still-in-support version of Node (14), and updated Travis to test only the currently supported LTS versions of Node (14, 16, and 18)

@leumasme
Copy link

Wondered about this as well after investigating useless packages like is-bigint in my node_modules.
I dont believe that this would be the correct way, however. At the very least, it would be a breaking change and require a major version bump.
Perhaps just adding a tiny selfwritten padEnd implementation here is a better idea? I don't think dropping support just for the sake of not supporting out-of-date node versions is useful.

@Pomax
Copy link
Author

Pomax commented Oct 17, 2022

No it wouldn't? It only changes internal code, not an external API or something. Sure, the node version got bumped, but then again, any Node version prior to 14 is fairly explicitly dead, given Node's support matrix. So if you have to, bump the major version (that's not something a PR should be doing though, that's the release maintainer's job through npm version major).

@jimmywarting
Copy link

jimmywarting commented Jan 11, 2023

👍 lgtm, would be nice to get rid of all those sub dependencies


it's fine to to a minor release as long as you bump the engines.node accordingly to the nodejs version that supports native pad. The node version in package.json will safe guard against this kind of changes and just install the version that are most suitable for the node version that you have installed.

(have a old nodejs version installed? then it will install an older release)

Really the only time that it requires a major release is when your public api changes and you can't use the same code you have already been using

@zm-cttae-archive
Copy link

@mysticatea tech debt PR, please review+merge if you can

@Lucienest
Copy link

this project seems to have abandoned

@zm-cttae-archive
Copy link

zm-cttae-archive commented Feb 28, 2023 via email

@Pomax
Copy link
Author

Pomax commented Mar 22, 2023

No eyes on this in over 6 months: I'm going to assume that you're not interested in PRs, @mysticatea, and I don't want to see this clog up my outstanding PR list going forward. Feel free to reopen and merge in if you're still going to have a look.

@Pomax Pomax closed this Mar 22, 2023
@Lucienest
Copy link

the owner of this repo is still active but abandoned this project, no update since 2019, pathetic
@Pomax

@zm-cttae-archive
Copy link

please delete the last word... fwiw we can fork the package and publish this PR and all others

it would just be called npm-run-all-more

@Lucienest
Copy link

please delete the last word... fwiw we can fork the package and publish this PR and all others

it would just be called npm-run-all-more

what else should I say? that's the truth
The project got abandoned, we can fork for sure but
that doesn't change the fact.

@jimmywarting
Copy link

As a maintainer of other big open source projects i think it feels kind of hostile, unappreciated and unnecessary.
When somebody say something negative, specially when someone puts hes heart and sole into building something free without earning anything but the communities love and respect back.

Negativity leads to developer to no longer wanting to maintain anything more for free.

By using a more neutral and factual tone, you can still convey the information without adding any negativity or judgment to it. It's important to remember that open source projects are often maintained by volunteers, and we should always show appreciation for their contributions, regardless of their level of activity or availability.

@zm-cttae-archive
Copy link

zm-cttae-archive commented Mar 31, 2023

This was going to be a dead (really "remummified zombie") npm ticket. But someone did the 5-minute mile & made an open-source solution. Their code and review work will always remain ~90% of the total project effort even if the community forks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove string.prototype.padend dependency
6 participants