-
-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove padend dependency #242
Conversation
This replaces the use of the string.prototype.padend dependency with the normal String.padEnd function, removing the need for 3.3Mb of dependencies.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems also need to bump node
in engines
field to 8 and remove node
less than 8 from .travis.yml
.
good point, bumped up the engine requirement to the oldest still-in-support version of Node (14), and updated Travis to test only the currently supported LTS versions of Node (14, 16, and 18) |
Wondered about this as well after investigating useless packages like is-bigint in my node_modules. |
No it wouldn't? It only changes internal code, not an external API or something. Sure, the node version got bumped, but then again, any Node version prior to 14 is fairly explicitly dead, given Node's support matrix. So if you have to, bump the major version (that's not something a PR should be doing though, that's the release maintainer's job through |
👍 lgtm, would be nice to get rid of all those sub dependencies it's fine to to a minor release as long as you bump the (have a old nodejs version installed? then it will install an older release) Really the only time that it requires a major release is when your public api changes and you can't use the same code you have already been using |
@mysticatea tech debt PR, please review+merge if you can |
this project seems to have abandoned |
Hi Toru,
There's a PR to slim down npm-run-all significantly over at mysticatea/npm-run-all#242<#242>.
Please review when you get a chance! (Again this could be 1 week, 1 month or any amount of time.)
…________________________________
From: Lucien Nocelli ***@***.***>
Sent: 28 February 2023 13:23
To: mysticatea/npm-run-all ***@***.***>
Cc: M00TSDNS ***@***.***>; Comment ***@***.***>
Subject: Re: [mysticatea/npm-run-all] remove padend dependency (PR #242)
this project seems to have abandoned
—
Reply to this email directly, view it on GitHub<#242 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/A5MVIFXFH5RGJHVAMPEWHUTWZX34FANCNFSM6AAAAAAQENSUVM>.
You are receiving this because you commented.Message ID: ***@***.***>
|
No eyes on this in over 6 months: I'm going to assume that you're not interested in PRs, @mysticatea, and I don't want to see this clog up my outstanding PR list going forward. Feel free to reopen and merge in if you're still going to have a look. |
the owner of this repo is still active but abandoned this project, no update since 2019, pathetic |
please delete the last word... fwiw we can fork the package and publish this PR and all others it would just be called |
what else should I say? that's the truth |
As a maintainer of other big open source projects i think it feels kind of hostile, unappreciated and unnecessary. Negativity leads to developer to no longer wanting to maintain anything more for free. By using a more neutral and factual tone, you can still convey the information without adding any negativity or judgment to it. It's important to remember that open source projects are often maintained by volunteers, and we should always show appreciation for their contributions, regardless of their level of activity or availability. |
This was going to be a dead (really "remummified zombie") npm ticket. But someone did the 5-minute mile & made an open-source solution. Their code and review work will always remain ~90% of the total project effort even if the community forks. |
This replaces the use of the string.prototype.padend dependency with the normal String.padEnd function, removing the need for 3.3Mb of dependencies.
This PR fixes #241