Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: remove ng modules #210

Merged
merged 4 commits into from
Jul 14, 2024
Merged

feat!: remove ng modules #210

merged 4 commits into from
Jul 14, 2024

Conversation

NachoVazquez
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines: CONTRIBUTING.md#commit
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

NgModules are deprecated but they are still part of the library

What is the new behavior?

We have completely removed the NgModules from the source code.

Does this PR introduce a breaking change?

[x] Yes
[ ] No

NgModules can not be used anymore to configure the library, only provider functions can be used now.

Copy link

nx-cloud bot commented Jul 14, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 8f98662. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 5 targets

Sent with 💌 from NxCloud.

Copy link

sonarcloud bot commented Jul 14, 2024

@NachoVazquez NachoVazquez merged commit 7cb8941 into main Jul 14, 2024
7 checks passed
@NachoVazquez NachoVazquez deleted the feature/remove-ng-modules branch July 14, 2024 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant