feat: support request cache control directives #3658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flakey5
force-pushed
the
flakey5/20240924/cli-cache-control
branch
from
3ebfdd8
to
9a15ece
Compare
mcollina
reviewed
Oct 15, 2024
lib/interceptor/cache.js
Outdated
| return dispatch(opts, new CacheHandler(globalOpts, opts, handler)) | ||
| } | ||
|
|
||
| const { value } = stream | ||
|
|
||
| const now = Date.now() |
There was a problem hiding this comment.
Please use
Line 390 in 770b2db
flakey5
force-pushed
the
flakey5/20240924/cli-cache-control
branch
from
9a15ece
to
a0b52e3
Compare
flakey5
force-pushed
the
flakey5/20240924/cli-cache-control
branch
from
a0b52e3
to
d034c54
Compare
flakey5
force-pushed
the
flakey5/20240924/cli-cache-control
branch
from
d034c54
to
13fe5e0
Compare
Signed-off-by: flakey5 <[email protected]>
flakey5
force-pushed
the
flakey5/20240924/cli-cache-control
branch
from
13fe5e0
to
4c3dd04
Compare
|
cc @ronag PTAL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: this is a draft since #3562 isn't landed. Until it is landed, this will be based off of that pr's branch. For the actual diff see flakey5/undici@flakey5/3231...flakey5:undici:flakey5/20240924/cli-cache-controlThis relates to...
Adding client side http caching (#3562)
Rationale
Changes
Features
RFC9111 allows the request to specify a cache-control header with directives that can affect how we handle the request in the cache interceptor (re 5.2.1). This adds support for them.
Bug Fixes
Breaking Changes and Deprecations
Status
cc @mcollina @ronag