Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python update, first update for ohw-spanish '24 intermediate workshop event #91

Merged
merged 2 commits into from
Oct 3, 2024

Conversation

emiliom
Copy link
Member

@emiliom emiliom commented Oct 2, 2024

First update to one of the kernel images, for the OHW24-in-Spanish October event ("Intermediate workshop" -- tutorials only). For more info about the changes planned, see oceanhackweek/Hub-Management#6 and 2i2c-org/infrastructure#4883

Removes the OHW24 (mothership) pixi tutorial "feature" dependencies and adds new ones corresponding to the upcoming tutorials. Also removes pixi-kernel, so the other kernels don't show up in JupyterLab.

@emiliom
Copy link
Member Author

emiliom commented Oct 3, 2024

The build fails (https://github.com/oceanhackweek/jupyter-image/actions/runs/11153335706/job/31000638781?pr=91#step:1:36). The error message is "Error: This request has been automatically failed because it uses a deprecated version of actions/upload-artifact: v1. Learn more: https://github.blog/changelog/2024-02-13-deprecation-notice-v1-and-v2-of-the-artifact-actions/"

I didn't touch the github action workflows, and things obviously were working for OHW24 as recently as 5 weeks ago. All I'm doing in this PR is replacing the feature dependencies, mostly with fairly basic libraries. Plus removing pixi-kernel.

I'll push a commit to this PR to update actions/upload-artifact to v3. The upload-artifact market page says that v1 & v2 were scheduled for deprecation, v3 will be deprecated on Nov. 30, and one should update to v4. I'm doing v3 to minimize potential impact from breaking changes, for now.

@emiliom emiliom requested a review from abkfenris October 3, 2024 00:33
@emiliom
Copy link
Member Author

emiliom commented Oct 3, 2024

@abkfenris this being my first update to the images since OHW24, and since the changeover to pixi, could you review this PR? Thanks.

Copy link
Collaborator

@abkfenris abkfenris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that should work. Did you try make py-build py-lab and see if you had the packages you wanted in Jupyterlab locally?

I'm still figuring out the best way to use features, so while we can also look at the old pixi.toml features in git, we could also not include them in the environments if we wanted to keep them around, say if we recorded them more as tutorial type. Then per event we could toggle on/off different features based on the tutorials.

@emiliom
Copy link
Member Author

emiliom commented Oct 3, 2024

Thanks! I did use py-build and py-lab. I hadn't checked the packages on JupyterLab proper (I did on the shell after doing pixi shell), but I just did and they're there. FYI, all the other kernels are also showing, despite removing pixi-kernel, but I'll look into that in a later PR.

I also hesitated about removing the OHW24 features vs not including them in the default environment. But in the end I wanted to be extra sure.

I'll go ahead and merge. Thanks again.

@emiliom emiliom merged commit 27d5f52 into oceanhackweek:main Oct 3, 2024
4 checks passed
@abkfenris
Copy link
Collaborator

Hmm, it looks like pixi-kernel is removed from the lockfile, so the other kernels shouldn't be shown...

@abkfenris
Copy link
Collaborator

If I make py-build py-lab I'm only showing ipykernel so I think we should be good.

image

@emiliom
Copy link
Member Author

emiliom commented Oct 3, 2024

Ah. I was doing just make py-lab. Sure enough, when I used make py-build py-lab, the other pixi kernels are gone. Great!

@emiliom
Copy link
Member Author

emiliom commented Oct 3, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants