-
-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: a11y fail click events have key events and no static element interactions #4169
fix: a11y fail click events have key events and no static element interactions #4169
Conversation
✅ Deploy Preview for oss-insights ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Thanks for all the screenshots for before and after @FatumaA. So we can move this along, can you exclude changes that currently break the UI and we can sort those out in a follow up PR? Also, thanks for your patience! |
No problem, thank you for yours! I think the radio and radio check should be a simple fix on the button classes, we should keep the fix in this PR; what do you think? As for the devwallcard component, I will undo the changes and leave it out as you've suggested. |
For the radio and radio check feel free to put the fix in here, but also, if you want to take a bit of time, like I said, it can go in a follow up PR. |
…-and-no-static-element-interactions-
This seems to all be working great. The only thing I noticed is the search no longer auto focuses when you click on the search button or press CMD + K (macOS) or CTRL + K (other OSes). |
I removed the auto focus on the components, let me look into it |
Head branch was pushed to by a user without write access
…nd-no-static-element-interactions-
@nickytonline I pushed a fix for that, but I noticed the component uses global document methods. Is there any particular reason, or is this up for a refactor? |
@FatumaA, I'll take a peek at this tomorrow. |
…-and-no-static-element-interactions-
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this @FatumaA! 🚢
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nit about the .env
Co-authored-by: Brandon Roberts <[email protected]>
## [2.64.1-beta.2](v2.64.1-beta.1...v2.64.1-beta.2) (2024-10-31) ### 🐛 Bug Fixes * a11y fail click events have key events and no static element interactions ([#4169](#4169)) ([f86e76b](f86e76b))
Description
Addresses the accessibility problems in the files listed in the linked issue.
Related Tickets & Documents
Fixes #4130
Mobile & Desktop Screenshots/Recordings
AuthSection:
CardRepoList:
ContributorFilterDropdown:
ContributorHighLightCard:
Neutral and hiver states remain same -
ContributorlistTableRow:
No diff, except it now has a cursor on hover:
DevCard:
HighlightFilterCard:
HighlightInputForm close button:
HighlightInputForm - suggested links:
PillSelector:
RepositoryCartItem:
Search:
Search-dialog:
SuperlativeSelector:
Unselected -
Selected -
TextInput:
ToggleOption:
With Icon
Card in pages/u/[username]/Card.tsx:
Radio and Radio Check:
Steps to QA
Run
npx eslint .
in the root folder, and see that those errors are no longer occurringTier (staff will fill in)
[optional] What gif best describes this PR or how it makes you feel?