Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Instrumentation.EFCore] Support together with Instrumentation.SqlClient #2280

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

zivaninstana
Copy link
Contributor

@zivaninstana zivaninstana commented Oct 31, 2024

Fixes #1764
Design discussion issue #

Changes

#1764 (comment)

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@zivaninstana zivaninstana requested a review from a team as a code owner October 31, 2024 12:01
@github-actions github-actions bot added the comp:instrumentation.entityframeworkcore Things related to OpenTelemetry.Instrumentation.EntityFrameworkCore label Oct 31, 2024
@zivaninstana zivaninstana changed the title EF Core and SqlClient instrumentation enabled at the same time produc… [EF Core] EF Core and SqlClient instrumentation enabled at the same time produc… Oct 31, 2024
Copy link

codecov bot commented Oct 31, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 56.77%. Comparing base (71655ce) to head (0e33045).
Report is 588 commits behind head on main.

Files with missing lines Patch % Lines
...mplementation/EntityFrameworkDiagnosticListener.cs 87.50% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2280       +/-   ##
===========================================
- Coverage   73.91%   56.77%   -17.15%     
===========================================
  Files         267        5      -262     
  Lines        9615      192     -9423     
===========================================
- Hits         7107      109     -6998     
+ Misses       2508       83     -2425     
Flag Coverage Δ
unittests-Instrumentation.EntityFrameworkCore 56.77% <87.50%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...mplementation/EntityFrameworkDiagnosticListener.cs 52.63% <87.50%> (+0.25%) ⬆️

... and 263 files with indirect coverage changes

@Kielek
Copy link
Contributor

Kielek commented Oct 31, 2024

Please add CHANGELOG.md entry

@Kielek Kielek changed the title [EF Core] EF Core and SqlClient instrumentation enabled at the same time produc… [Instrumentation.EFCore] Support together with Instrumentation.SqlClient Oct 31, 2024
@CodeBlanch
Copy link
Member

Please add CHANGELOG.md entry

A test would be great as well! Is it possible to model a test for this fix?

@zivaninstana
Copy link
Contributor Author

zivaninstana commented Nov 1, 2024

Please add CHANGELOG.md entry

A test would be great as well! Is it possible to model a test for this fix?

I will see what can be implemented 👍

@lachmatt lachmatt removed their assignment Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:instrumentation.entityframeworkcore Things related to OpenTelemetry.Instrumentation.EntityFrameworkCore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EF Core and SqlClient instrumentation enabled at the same time produce wrong spans
4 participants