-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Instrumentation.Http] fall back in case of NET9. update unit tests #2314
base: main
Are you sure you want to change the base?
[Instrumentation.Http] fall back in case of NET9. update unit tests #2314
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2314 +/- ##
==========================================
- Coverage 73.91% 68.24% -5.67%
==========================================
Files 267 363 +96
Lines 9615 13816 +4201
==========================================
+ Hits 7107 9429 +2322
- Misses 2508 4387 +1879
Flags with carried forward coverage won't be shown. Click here to find out more.
|
.github/workflows/ci.yml
Outdated
@@ -324,6 +324,7 @@ jobs: | |||
with: | |||
project-name: Component[OpenTelemetry.Instrumentation.Http] | |||
code-cov-name: Instrumentation.Http | |||
tfm-list: '[ "net462", "net8.0", "net9.0" ]' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I need to add NET9 to the CI. I'm checking offline to confirm if this is the correct way to make that change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After #2313 gets merged, net9.0
would run for all jobs by default. You won't need to configure for this individual job.
src/OpenTelemetry.Instrumentation.Http/OpenTelemetry.Instrumentation.Http.csproj
Outdated
Show resolved
Hide resolved
@TimothyMothra As we discussed offline, please evaluate if we need to cover the .NET 9.0 gaps for |
I opened a tracking issue in Runtime: dotnet/runtime#109847 |
test/OpenTelemetry.Instrumentation.Http.Tests/OpenTelemetry.Instrumentation.Http.Tests.csproj
Outdated
Show resolved
Hide resolved
…mothyMothra/opentelemetry-dotnet-contrib-fork into 2029_httpinstrumentation_net9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR looks pretty good, but looks like there's some build issues.
Co-authored-by: Alan West <[email protected]>
Thanks!
Sigh. Visual Studio keeps saving files with Windows line endings (CR LF), but this repo expects Unix line endings (LF). |
Fixes #2029
Net9 added support for Http semantic convention attributes here: dotnet/runtime#104251
Changes
Merge requirement checklist
CHANGELOG.md
files updated for non-trivial changes