Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove grpc class options from OTLPExporter. Make Endpoint Uri for all frameworks #1789

Merged
merged 3 commits into from
Feb 5, 2021

Conversation

cijothomas
Copy link
Member

Option 2 from #1778 (comment)

This PR makes Endpoint as Uri for both framework targets.
It removes from OTLPOptions anything tied to Grpc classes. This means users no longer have the ability to use OTLPExporter with TLS.
If https Endpoint is specified, throws at ctor() saying Https is unsupported.

In 1.1, proper support can be added for TLS without requiring breaking changes.

@codecov
Copy link

codecov bot commented Feb 4, 2021

Codecov Report

Merging #1789 (032e8b0) into main (416a6c1) will increase coverage by 0.68%.
The diff coverage is 70.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1789      +/-   ##
==========================================
+ Coverage   83.14%   83.83%   +0.68%     
==========================================
  Files         193      187       -6     
  Lines        6005     5952      -53     
==========================================
- Hits         4993     4990       -3     
+ Misses       1012      962      -50     
Impacted Files Coverage Δ
...nTelemetry.Exporter.Jaeger/Implementation/Batch.cs 84.09% <ø> (+3.65%) ⬆️
....Exporter.Jaeger/JaegerExporterHelperExtensions.cs 15.38% <ø> (ø)
...Telemetry.Exporter.Jaeger/JaegerExporterOptions.cs 100.00% <ø> (ø)
...metryProtocol/OtlpTraceExporterHelperExtensions.cs 92.30% <ø> (ø)
....Exporter.Zipkin/ZipkinExporterHelperExtensions.cs 15.38% <ø> (ø)
...Telemetry.Exporter.Zipkin/ZipkinExporterOptions.cs 100.00% <ø> (ø)
...xporter.OpenTelemetryProtocol/OtlpTraceExporter.cs 46.37% <37.93%> (-11.08%) ⬇️
...rc/OpenTelemetry.Exporter.Jaeger/JaegerExporter.cs 85.00% <84.21%> (-0.27%) ⬇️
...orter.OpenTelemetryProtocol/OtlpExporterOptions.cs 100.00% <100.00%> (ø)
...rc/OpenTelemetry.Exporter.Zipkin/ZipkinExporter.cs 87.64% <100.00%> (+0.14%) ⬆️
... and 10 more

Copy link
Member

@CodeBlanch CodeBlanch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cijothomas cijothomas marked this pull request as ready for review February 5, 2021 00:01
@cijothomas cijothomas requested a review from a team February 5, 2021 00:01
@cijothomas cijothomas merged commit 19cf0c9 into main Feb 5, 2021
@cijothomas cijothomas deleted the cijothomas/otlpoption_uri branch February 5, 2021 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants