-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Instrumentation page #5523
base: main
Are you sure you want to change the base?
Instrumentation page #5523
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move this file to the folder content/en/docs/concepts/instrumentation
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
undo this change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing both lines takes it back to the original (looks better) so let me go with that. Thank you
@@ -5,6 +5,8 @@ aliases: [instrumenting] | |||
weight: 15 | |||
--- | |||
|
|||
![ Native Instrumentation vs instrumentation libraries](/img/libraries-instrumentation.svg) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
update this with the right URL after you have moved the file to the right location
@@ -5,6 +5,8 @@ aliases: [instrumenting] | |||
weight: 15 | |||
--- | |||
|
|||
![ Native Instrumentation vs instrumentation libraries](/libraries-instrumentation.svg) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
![ Native Instrumentation vs instrumentation libraries](/libraries-instrumentation.svg) | |
![ Native Instrumentation vs instrumentation libraries](libraries-instrumentation.svg) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The original issue:
said to move the image. So you also need to delete it from https://github.com/open-telemetry/opentelemetry.io/blob/main/static/img/libraries-instrumentation.svg.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please trim out the excessive whitespace around the image content.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, consider renaming this file native-vs-libraries.svg
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I trimmed the excessive whitespace around the image content and renamed the file to native-vs-libraries.svg. Please let me know if you need any further adjustments.
Moved an image from the libraries page to the instrumentation page.