Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instrumentation page #5523

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

DIANAAJAMBO
Copy link
Contributor

Moved an image from the libraries page to the instrumentation page.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move this file to the folder content/en/docs/concepts/instrumentation

Comment on lines 25 to 26


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

undo this change

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing both lines takes it back to the original (looks better) so let me go with that. Thank you

@@ -5,6 +5,8 @@ aliases: [instrumenting]
weight: 15
---

![ Native Instrumentation vs instrumentation libraries](/img/libraries-instrumentation.svg)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update this with the right URL after you have moved the file to the right location

@@ -5,6 +5,8 @@ aliases: [instrumenting]
weight: 15
---

![ Native Instrumentation vs instrumentation libraries](/libraries-instrumentation.svg)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
![ Native Instrumentation vs instrumentation libraries](/libraries-instrumentation.svg)
![ Native Instrumentation vs instrumentation libraries](libraries-instrumentation.svg)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please trim out the excessive whitespace around the image content.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, consider renaming this file native-vs-libraries.svg.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I trimmed the excessive whitespace around the image content and renamed the file to native-vs-libraries.svg. Please let me know if you need any further adjustments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants