-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: bump RTE version to v0.19.0 #988
base: main
Are you sure you want to change the base?
Conversation
Update dependency version to consume latest updates. addresses: openshift-kni#978 Signed-off-by: Shereen Haj <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: shajmakh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
this will require evaluating the transition to the new APIs (e.g. move to config files rather than the bunch of options we are using) and regression testing example of how it could look like: k8stopologyawareschedwg/resource-topology-exporter#256 [EDIT] we can stay with the old-style commandline option and defer the transition to the configfile, but we should make a plan/timeline for the transition to configfile. |
/hold |
I recommend to the take the opportunity of supporting NROP on HCP, and:
|
Thanks for sharing, good idea indeed for the 4.18 branch. I'll note that to apply it when we branch. |
@shajmakh: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Update dependency version to consume latest updates.
addresses: #978