-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update compatibility.md
re. TruffleRuby 24.0
#3530
base: master
Are you sure you want to change the base?
Conversation
ParadoxV5
commented
Apr 15, 2024
Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA).
To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application. When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated. If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public. |
Man… this process is so clunky. [P.S.] |
Thank you for signing the OCA. |
TruffleRuby does not yet implement Ruby 3.3 features, and that's why there is also no Ruby 3.3 issue yet (it will be created when work starts on it). TruffleRuby does support Ruby 3.3 syntax, because that is the minimum version that Prism supports and we have implemented all Prism nodes. Looking at https://github.com/ruby/ruby/blob/master/doc/NEWS/NEWS-3.3.0.md there does not seem to be NEWS-worthy syntax changes in 3.3 (although probably there are some small fixes). |
Thank you for your clarification. There weren’t a lot of feature improvements listed in https://github.com/ruby/ruby/blob/v3_3_0/NEWS.md.
I would like to be more optimistic and retain the 3.3 syntax announcement by clarifying that library features are not yet 3.3. |
That could be done, OTOH it's significantly easier to contribute once the RUBY_VERSION has been bumped, and that can only be done after importing the updated files from CRuby (otherwise there are basically 2 versions, that works OK-ish with
The line is only about syntax and parser, so it feels out of place to mention core library/standard library there. Also in general I think we won't mention updates to syntax much in the changelog anymore, since we'll just update Prism regularly and get the new syntax early when updating to a new Ruby version. |
How’s the roadmap looking?
I agree: the bullet point explicitly mentions the adoption of Prism.
People (including me) will not enjoy the changelogs seemingly hanging the syntax compability at Ruby 3.3/3.2 with no further updates. |
(for some reason your last reply didn't get notified on Slack via the integration, weird)
We plan to do the Ruby 3.3 import but there are several more important things to finish first, notably we're reviewing several things related to performance.
We typically avoid indented bullets in the changelog.
The idea is we will have things like |
https://github.com/oracle/truffleruby/releases/tag/graal-24.0.0 Does _not_ mention Ruby 3.3 *syntax* as it’s currently the only Ruby 3.3 feature officially supported. The changelogs will also receive a clarification. See oracle#3530 Co-Authored-By: Benoit Daloze <[email protected]>
…fy re. Ruby 3.3 support
@@ -32,7 +32,7 @@ Memory Footprint: | |||
New features: | |||
|
|||
* C/C++ extensions are now compiled using the system toolchain and executed natively instead of using GraalVM LLVM (Sulong). This leads to faster startup, no warmup, better compatibility, smaller distribution and faster installation for C/C++ extensions (#3118, @eregon). | |||
* Full support for the Ruby 3.2 and Ruby 3.3 syntax by adopting the [Prism](https://github.com/ruby/prism) parser, which is about twice as fast as the old parser (#3117, #3038, #3039, @andrykonchin, @eregon). | |||
* Full support for the Ruby 3.2 (and Ruby 3.3) _syntax_ by adopting the [Prism](https://github.com/ruby/prism) parser, which is about twice as fast as the old parser (#3117, #3038, #3039, @andrykonchin, @eregon). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How’s this? Is it acceptable by Truffle’s style guidelines?
(I use _
over *
whenever underlining suits better than italicizing for the emphasis.)