add some todo for runtime tasks

commands/kubeadm_upgrade_apply.go

@@ -22,6 +22,7 @@ import (
 	operatorv1 "k8s.io/kubeadm/operator/api/v1alpha1"
 )
 
+// TODO this is a temporary hack to get the "kubeadm upgrade apply" to work
 func runKubeadmUpgradeApply(spec *operatorv1.KubeadmUpgradeApplyCommandSpec, log logr.Logger) error {
 	return nil
 }

commands/kubeadm_upgrade_node.go

@@ -22,6 +22,7 @@ import (
 	operatorv1 "k8s.io/kubeadm/operator/api/v1alpha1"
 )
 
+// TODO this is a temporary hack to get the "kubeadm upgrade node" to work
 func runKubeadmUpgradeNode(spec *operatorv1.KubeadmUpgradeNodeCommandSpec, log logr.Logger) error {
 	return nil
 }

commands/kubectl_drain.go

@@ -22,6 +22,7 @@ import (
 	operatorv1 "k8s.io/kubeadm/operator/api/v1alpha1"
 )
 
+// TODO this is a temporary hack to get the "kubectl drain" to work
 func runKubectlDrain(spec *operatorv1.KubectlDrainCommandSpec, log logr.Logger) error {
 	return nil
 }

commands/kubectl_uncordon.go

@@ -22,6 +22,7 @@ import (
 	operatorv1 "k8s.io/kubeadm/operator/api/v1alpha1"
 )
 
+// TODO this is a temporary hack to get the "kubectl uncordon" to work
 func runKubectlUncordon(spec *operatorv1.KubectlUncordonCommandSpec, log logr.Logger) error {
 	return nil
 }

commands/upgrade_kubeadm.go

@@ -22,6 +22,7 @@ import (
 	operatorv1 "k8s.io/kubeadm/operator/api/v1alpha1"
 )
 
+// TODO this is a temporary hack to get the upgrading kubeadm to work
 func runUpgradeKubeadm(spec *operatorv1.UpgradeKubeadmCommandSpec, log logr.Logger) error {
 	return nil
 }

commands/upgrade_kubectlkubelet.go

@@ -22,6 +22,7 @@ import (
 	operatorv1 "k8s.io/kubeadm/operator/api/v1alpha1"
 )
 
+// TODO this is a temporary hack to get the kubectl & kubelet upgrade to work
 func runUpgradeKubectlAndKubelet(spec *operatorv1.UpgradeKubeletAndKubeactlCommandSpec, log logr.Logger) error {
 	return nil
 }

controllers/operation_controller.go

@@ -131,6 +131,7 @@ func (r *OperationReconciler) reconcileDaemonSet(operation *operatorv1.Operation
 		return nil
 	}
 
+	// daemonset will be created only if the operation is in controlled mode.
 	if !daemonSetShouldBeRunning(operation) {
 		return nil
 	}

controllers/runtimetask_controller.go

@@ -237,10 +237,10 @@ func (r *RuntimeTaskReconciler) reconcileNormal(executionMode operatorv1.Operati
 	}
 
 	// Proceed with the current command execution
-
 	if executionMode == operatorv1.OperationExecutionModeDryRun {
 		// if dry running wait for an arbitrary delay so the user will get a better perception of the Task execution order
 		time.Sleep(3 * time.Second)
+		// TODO should we collect log for dry-run?
 	} else {
 		// else we should execute the CurrentCommand
 		log.WithValues("command", task.Status.CurrentCommand).Info("running command")