Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Windows default paths for docker.exe and docker-compose.exe #318

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

tifoha
Copy link

@tifoha tifoha commented Aug 7, 2019

Before this PR

this docker-compose-rule not working out of the box with windows machines, cause there are no default path to docker executables

After this PR

now it should work with windows

Possible downsides?

didn't find any downsides

@changelog-app
Copy link

changelog-app bot commented Aug 7, 2019

Generate changelog in changelog/@unreleased

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Added Windows default paths for docker.exe and docker-compose.exe

Before this PR

this docker-compose-rule not working out of the box with windows machines, cause there are no default path to docker executables

After this PR

now it should work with windows

Possible downsides?

didn't find any downsides

Check the box to generate changelog(s)

  • Generate changelog entry

@ferozco
Copy link
Contributor

ferozco commented Aug 22, 2019

@tifoha thanks for the contribution! There was a flake in the build that was resolved by #320, you'll want to rebase your branch to pick up the fix

@tifoha
Copy link
Author

tifoha commented Sep 4, 2019

I merged changes upstream into my fork.
Also I fixed warnings from gradle about using Guava Concurent hash set instead of standard JDK.
@ferozco Can you review my changes?

@tifoha tifoha mentioned this pull request Sep 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants