-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add insert storage #23
base: master
Are you sure you want to change the base?
Conversation
replikeit
commented
Oct 22, 2024
- Add function that change value in slot by address in database.
Upvoted 👍 |
Best feature ever! Thanks for PR |
we need this ASAP |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please fix the failing test
it's just a request rate limitation issue from the rpc provider i guess. |
The problem with this feature is that inserting account storage does not override the existing value |
================================================================================== test session starts =================================================================================== tests/test_evm.py F [100%] ======================================================================================== FAILURES ========================================================================================
E assert 10 == 20 tests/test_evm.py:71: AssertionError I modified the test "test_set_into_storage" to check for overriding the storage IDK if it's an intended behaviour but it's not stated in the underlying implementation. |
Hi, @aymantaybi I fixed your issue in that update, also added tests. Locally all tests have passed. |
I forgot to update version in python toml, sorry. |
@replikeit Thank you for your contribution, highly appreciate it! |