ui: Metrics graph highlighted point bug fix #4246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤖 Meticulous spotted visual differences in 23 of 396 screens tested: view and approve differences detected. Last updated for commit 91bcc66. This comment will update as new commits are pushed. |
yomete
reviewed
Jan 2, 2024
Comment on lines
+209
to
+210
| const x = xScale(d[0]) + margin / 2; | ||
| const y = yScale(d[1]) - margin / 3; |
There was a problem hiding this comment.
just curious here, why did adding a margin and dividing by 2/3 fix the bug?
There was a problem hiding this comment.
curious about this as well, does it maybe have to do with the 2.5 factor in the xScale setup?
There was a problem hiding this comment.
Yes, these are because of the additional padding that got introduced from the axis labels.
But still don't have a concrete explanation on why these fractions work. We need to figure that out as part of #4241.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.