Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

area/ui: rejig dashboard buttons #5276

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

yomete
Copy link
Contributor

@yomete yomete commented Nov 7, 2024

This is a PR that restructures the toolbar buttons.

Summary:

  • The "Sort by" button is moved within the context of the icicle graph.
  • The "Table columns" button is moved within the context of the table component.
  • The table component now has a column to display the color which can either be the filename or binary.
  • Hiding binaries now works with the table component
  • The color legend is now above both the icicle and table visualisations. it was previously located above the icicle viz only.

@yomete yomete requested a review from a team as a code owner November 7, 2024 14:55
Copy link

alwaysmeticulous bot commented Nov 7, 2024

🤖 Meticulous spotted visual differences in 214 of 306 screens tested: view and approve differences detected.

Meticulous simulated ~4 hours of user flows against your PR.

Last updated for commit 48e967f. This comment will update as new commits are pushed.

@yomete yomete changed the title area/ui: rejig dashboard buttons (wip) area/ui: rejig dashboard buttons Nov 13, 2024
Copy link
Contributor

@manojVivek manojVivek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants