Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Lowercase the custom levels only when useOnlyCustomLevels is true #2056

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: Lowercase the custom levels only when useOnlyCustomLevels is true #2056

wants to merge 2 commits into from

Conversation

ondrej-langr
Copy link

Typescript enums usually have uppercased keys. This change completely breaks implementation when the useOnlyCustomLevels option is set to true and the enum of custom levels includes DEBUG key.

@ondrej-langr ondrej-langr changed the title fix: Lowercase the custom levels when useOnlyCustomLevels is true fix: Lowercase the custom levels only when useOnlyCustomLevels is true Oct 7, 2024
@mcollina
Copy link
Member

CI is failing

@ondrej-langr
Copy link
Author

ondrej-langr commented Nov 12, 2024 •
edited
Loading

@mcollina hey, can you please look at this when you will have some time? Thanks

mcollina
mcollina requested changes Nov 12, 2024
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening a PR! Can you please add a unit test?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ondrej-langr @mcollina