fix: resolve symlinks in d.ts imports #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@privatenumber anything holding back? |
tests/specs/builds/symlink.ts
Outdated
| }); | ||
|
|
||
| export { index as default }; | ||
| `); |
There was a problem hiding this comment.
If this is a change on the declaration file, you should be checking index.d.ts instead of index.mjs
tests/specs/builds/symlink.ts
Outdated
| }, | ||
| }, | ||
| }, | ||
| }); |
There was a problem hiding this comment.
This test case seems unnecessarily convoluted just for checking symlinks
tests/specs/builds/symlink.ts
Outdated
| setup, | ||
| }: ComponentProps): ComponentProps; | ||
| `, | ||
| vue: { |
There was a problem hiding this comment.
Fixtures can be a lot simpler if we keep them pure and simple. Instead of trying to mock something thats a lot more than this, we should just call it dep-a and isolate the test to just testing symlinks.
privatenumber
changed the title
preserveSymlinks in tsconfig.json
|
Thanks for your contribution @jrson83 Hope we collaborate again in the future! |
|
🎉 This issue has been resolved in version 2.4.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have tried to implement
realPathconditionally where it is used.However, I realized that it is ultimately up to
rollup-plugin-dts, which usests.sysbut does not implementrealpathSync, to fix the problem.So we should set
preserveSymlinks: falseas default.I have written a test which mimics pnpm symlinks and fails without
preserveSymlinks: false.Closes #69