Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix utils functions with invalid ip/cidr inputs #6675

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Fix utils functions with invalid ip/cidr inputs #6675

wants to merge 8 commits into from

Conversation

vcapparelli
Copy link

@vcapparelli vcapparelli commented Mar 27, 2024 •
edited
Loading

Fixes #5131

@vcapparelli vcapparelli mentioned this pull request Mar 28, 2024
Open
@vcapparelli
Copy link
Author

@kennethreitz, @Lukasa, @sigmavirus24, @nateprewitt, @slingamn,

This is my first contribution to this project, and I don't know if is necessary request to someone to review the PR

Pjrich1313

This comment was marked as spam.

Sign in to view

@vcapparelli
Copy link
Author

@Pjrich1313,

Fast node isn't work

How can i test this case?

Pjrich1313

This comment was marked as spam.

Sign in to view

Pjrich1313
Pjrich1313 reviewed Oct 31, 2024
View reviewed changes
tests/test_utils.py
"1.1.1.1 someone was here...",
"localhost.localdomain",
),
)
def test_invalid(self, value):
assert not is_ipv4_address(value)

This comment was marked as spam.

Sign in to view

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pjrich1313 Pjrich1313 Pjrich1313 requested changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

requests.utils function accepts invalid ip/cidr input
2 participants
@vcapparelli @Pjrich1313