Preliminary support for outputting to OpenQASM 3.0 #6795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
dstrain115
commented
Nov 15, 2024
dstrain115
commented
- This supports changing the version and the obvious changes in outputting to OpenQASM 3.0
- This PR does not cover imports from OpenQASM 3.0
- This supports changing the version and the obvious changes in outputting to OpenQASM 3.0 - This PR does not cover imports from OpenQASM 3.0
pavoljuhas
reviewed
Nov 16, 2024
There was a problem hiding this comment.
Nice. Please consider using a version argument in public Circuit.to_qasm instead of QasmArgs, see the inline comment.
PS: Another patch to fix failing version test -
diff --git a/cirq-core/cirq/circuits/qasm_output_test.py b/cirq-core/cirq/circuits/qasm_output_test.py
index ad4e0d44..14abacc9 100644
--- a/cirq-core/cirq/circuits/qasm_output_test.py
+++ b/cirq-core/cirq/circuits/qasm_output_test.py
@@ -225,7 +225,7 @@ rx(pi*0.123) q[0];
def test_version():
(q0,) = _make_qubits(1)
with pytest.raises(ValueError):
- output = cirq.QasmOutput((), (q0,), version='3.0')
+ output = cirq.QasmOutput((), (q0,), version='4.0')
_ = str(output)
| if comment is None: | ||
| output(f'creg {meas_id}[{len(meas.qubits)}];\n') | ||
| if self.meas_comments[key] is not None: | ||
| comment = f' // Measurement: self.meas_comments[key]' |
There was a problem hiding this comment.
Suggested change
| comment = f' // Measurement: self.meas_comments[key]' | |
| comment = f' // Measurement: {self.meas_comments[key]}' |
| @@ -1362,8 +1364,10 @@ def to_qasm( | |||
| qubit_order: Determines how qubits are ordered in the QASM | |||
| register. | |||
| """ | |||
| output_precision = args.precision if args else precision | |||
There was a problem hiding this comment.
This overwrites the precision argument. Perhaps we could add a new version argument here instead and change the _qasm_ function to use _to_qasm_output instead of to_qasm.
This patch - circuit-to_qasm-with-version.patch.txt - does so and seems to pass the tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.