Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New apis from upstream #401

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

New apis from upstream #401

wants to merge 2 commits into from
+33 −0

Conversation

chqrlie
Copy link
Collaborator

@chqrlie chqrlie commented May 8, 2024

cherry-picked 2 simple commits from upstream:

  • Add `JS_HasException()
  • Add `JS_NewTypedArray()

kasperisager and others added 2 commits May 9, 2024 01:12
@kasperisager @chqrlie
Add JS_HasException() (quickjs-ng#265)
f3bf7af 
Author:    Kasper Isager Dalsgarð <[email protected]>
Date:      Wed May 8 23:19:15 2024 +0200
@xeioex @chqrlie
Add JS_NewTypedArray() (quickjs-ng#272)
044127b 
Author:    Dmitry Volyntsev <[email protected]>
Date:      Wed May 8 14:17:00 2024 -0700
@saghul
Copy link
Contributor

saghul commented May 9, 2024

Perhaps we should revisit the Uint8Array specific functions we added at some point.

@chqrlie
Copy link
Collaborator Author

chqrlie commented May 9, 2024 •
edited
Loading

Perhaps we should revisit the Uint8Array specific functions we added at some point.

Indeed, I am not sure about the arguments to C API JS_NewTypedArray. It should probably take a length and a const void * to optionally initialize the array contents.

@saghul
Copy link
Contributor

saghul commented Jun 24, 2024

Shall we land this? We can improve the APIs once in?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saghul saghul saghul approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chqrlie @saghul @kasperisager @xeioex