Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add createRequestListener to @react-router/node #12277

Draft
wants to merge 7 commits into
base: dev
Choose a base branch
from

Conversation

mjackson
Copy link
Member

@mjackson mjackson commented Nov 14, 2024

This PR adds a createRequestListener function to @react-router/node using @mjackson/node-fetch-server under the hood.

This PR also removes the streaming utilities from @react-router/node since node has decent (although experimental) built-in solutions for most of these use cases. e.g. you can use node's built-in Readable.fromWeb function to create a ReadableStream from a node Readable.

Note: This PR needs a CJS release of @mjackson/node-fetch-server before we can merge.

Copy link

changeset-bot bot commented Nov 14, 2024

🦋 Changeset detected

Latest commit: b33d82f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 10 packages
Name Type
@react-router/node Patch
@react-router/dev Patch
@react-router/serve Patch
@react-router/fs-routes Patch
@react-router/remix-routes-option-adapter Patch
react-router Patch
react-router-dom Patch
@react-router/architect Patch
@react-router/cloudflare Patch
@react-router/express Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mjackson mjackson marked this pull request as draft November 14, 2024 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant