Upgrade vlucas/phpdotenv to ^4.0.1 & fix breaking change #485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austinpray
reviewed
Dec 9, 2019
|
@kellymears Do you want to add this too?: #474 (comment) I was gonna create a PR (per swalk's request), but it would conflict with this PR, so might as well combine them. |
|
no combine pls: keep these pr topics separate |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #484
vlucas/phpdotenv> 4.0.0 has a breaking change as the initialization method has been split up and the old method has been removed.The new methods require you to specify if the env definitions are immutable or mutable.
This PR addresses this incompatibility by implementing the new
Dotenv::createImmutablemethod. I don't think Bedrock is doing any overloading, so this is probably the better practice.