Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Fix: Fix NOAUTH when using Sentinel with Password #354

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

neil-pozetroninc
Copy link

Currently when using Sentinel the password from the config is not passed through to the Sentinel class which results in a NOAUTH when connecting.

This patch passes through the same PASSWORD from the config through to both the Sentinel and the Master. This may not be what you want but it will solve the problem if both passwords are the same.

@selwin
Copy link
Collaborator

selwin commented Jun 24, 2019

Could you please fix the test errors so I can merge this in?

@neil-pozetroninc
Copy link
Author

I can, but is this the approach you want to take? There are several ways to address this bug, for example you may want another config value for the SENTINEL password instead.

Please let me know if this is your preferred approach.

@selwin
Copy link
Collaborator

selwin commented Jul 5, 2019

I think it would be better if the user can explicitly specify auth credentials to sentinels.

Merge from upstream
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants