Use a transaction when enqueuing a job to ensure atomicity #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
selwin
reviewed
Apr 24, 2020
| pipe.execute() | ||
| return | ||
|
|
||
| next_scheduled_time = ( |
There was a problem hiding this comment.
Could you explain the rationale behind changing the way which next_scheduled_time calculation is different than the current implementation?
|
Sorry for the late reply, I'd like to get this merged in if you could just address my comment here: #223 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suppose the scheduler receives a SIGKILL. If this happens between
zremandzaddinenqueue_job()the repeatable or cron jobs might stop working properly altogether. This is because the job is first consumed from Redis and later added in the sorted set with a score that's the future time at which it will run.To solve this, I propose using a transaction in
enqueue_job. This would assure the atomicity of the sequence of operations.