Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow sorting gems alphabetically in the Profile show page #4471

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

heyapricot
Copy link

Hi! 👋 Looking at #3270, the idea of sorting gems in the rubygems.org page resonated with me. While this Pull Request does not implement all the sorting options mentioned in the issue (yet), it tries to lay the foundation for allowing to sort the gems displayed in the page.

If this approach is accepted, some follow-up questions are:

  • Would this be implemented in other pages? (e.g. search results)
  • How should we handle toggling between ascending or descending order?

Thanks for taking the time to review this! ☺️

@heyapricot heyapricot force-pushed the profile-show-gem-sort branch 3 times, most recently from 3ed26fb to 43b475e Compare February 20, 2024 23:10
@simi
Copy link
Member

simi commented Feb 25, 2024

Hello and thanks for opening this PR.

currently it looks aligned well on wide screen

image

but seems off on tiny screen

image

Is that intended?

@martinemde @segiddins any ideas how to make gem lists sortable for now? There are various ways to manipulate rendered collections like this one on games page.

image

There is other filter on search page.

image

@heyapricot what's your usecase for this?

@heyapricot
Copy link
Author

@simi I was tackling issues from the list and on a personal note I've always been curious why sorting isn't an option

@heyapricot
Copy link
Author

@simi Fixed the alignment issue on mobile

Copy link

codecov bot commented Mar 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.15%. Comparing base (d5ec157) to head (b9e75bf).
Report is 72 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4471   +/-   ##
=======================================
  Coverage   97.15%   97.15%           
=======================================
  Files         391      391           
  Lines        8260     8261    +1     
=======================================
+ Hits         8025     8026    +1     
  Misses        235      235           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

2 participants