Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding some German resource love. #26

Open
wants to merge 1 commit into
base: dotnet5
Choose a base branch
from

Conversation

DennisGaida
Copy link

Had to recompile as described in #23 but also add some German resources. Maybe these help others.

Copy link

@nils-a nils-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it!

@DavidRieman
Copy link
Contributor

DavidRieman commented Oct 21, 2022

This word list is really big. Here's a couple problems:

  • Inefficient: It contains lots of duplicates.
  • Very large file: It contains really long words that kids are unlikely to be typed and wouldn't fit well stylistically on a screen if it was typed. (By comparison, the English version is only 14 KB. As-is this one word list would become a huge % of the package size.)
  • Not clear from PR alone if the words list was sourced responsibly in a kids-friendly and open-source-safe manner. (Do we have a German speaker willing to pore through the whole thing as-is?)

I've been considering merging several localizations / loc features into my own branch for the community's benefit. So LMK if someone is willing to address the words list issues.

@DennisGaida
Copy link
Author

I didn’t put that much thought into the word list and I know of no open-source kid-friendly German word list, but yes you have valid points. All I wanted is some German resource love and of course this may be improved upon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants