Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for pt-PT (Portuguese language, Portugal country "variation") #37

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

HelderMagalhaes
Copy link

This is part 1 of PR, including string resources for translation of shapes and colors

To whoever doesn't want to wait for next release or manually build the project:

  1. Within your BabySmash directory (or next to BabySmash.exe if you're using the single file archive), create a Resources\Strings (note: two folders, nested)
  2. Download pt-PT.json (included in this PR) inside Strings folder

A related glitch was identified, in PlaySound, where the reading is hard-coded to <color> <shape> order; in Portuguese, that will by default be the reverse <shape> <color>; guessing that a parameter stating the order will be enough, possibly as part of string resources — Question:
Is there any known language that is dynamic regarding the shape-color ordering?
A follow-up might be added to this PR ("part 2") or as separate PR if this is reviewed/merged in the meantime.

Added pt-PT (Portuguese language, Portugal country "variation") string resources
Copy link
Contributor

@DavidRieman DavidRieman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a native speaker, but syntax looks good to me, and those feel right.

But yes on the glitch, ideally, assuming we're using e.g. ICU message syntax, we'd add a string whose template is like {shape} {color} or change to {color} {shape} for some language/locale and pass those in to the resource retrieval instead of hard-coded string concatenation. (Then per your concern, if any language did need to change the order dynamically they'd do so with a more complex selector in the ICU message template, so even though that feels very unlikely, it is still covered.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants