-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement i8
and detect types correctly in MySQL
#454
Conversation
Oh oops, there's some warnings failing CI that aren't your fault. I'll get those fixed, then you can rebase them back into this PR. At a cursory glance your code looks good, but I'll look more in depth later. edit: fixes merged, you can sync with master (there might be .lock conflicts, sorry) |
Cool, thank you! |
@iamwacko thanks, I imported the updated |
Also, sorry @iamwacko for the formatting changes in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Imo, formatting changes in unrelated sections are fine in feature PRs. We don't really need more PR's that don't have substantive practical effects |
If you want to add any more changes, PR's are always welcome |
Hi friends!
Came across an issue when trying to
import
from a MySQL source on a schema that made use ofTINYINT
columns, and found a couple of other discrepancies with what I understood to be the type translation as specified in the docs.I am not very experienced in Rust, and I am primarily basing the work here on prior art.
We'll probably want the following:
u8
as well?Thank you!