Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement i8 and detect types correctly in MySQL #454

Merged
merged 10 commits into from
Sep 25, 2024

Conversation

tom-stytch
Copy link
Contributor

Hi friends!

Came across an issue when trying to import from a MySQL source on a schema that made use of TINYINT columns, and found a couple of other discrepancies with what I understood to be the type translation as specified in the docs.

I am not very experienced in Rust, and I am primarily basing the work here on prior art.

We'll probably want the following:

  • Extend the test scenarios to the Postgres cases, and/or confirm that these changes don't break some changes somewhere
  • Bump a version - I think these might be considered breaking changes somewhat
  • Add support for u8 as well?
    • This will also make the testing schema modification I made less nonsensical, I don't know what negative freckle count means 🤷

Thank you!

@iamwacko
Copy link
Collaborator

iamwacko commented Sep 18, 2024

Oh oops, there's some warnings failing CI that aren't your fault. I'll get those fixed, then you can rebase them back into this PR.

At a cursory glance your code looks good, but I'll look more in depth later.

edit: fixes merged, you can sync with master (there might be .lock conflicts, sorry)

@tom-stytch
Copy link
Contributor Author

Oh oops, there's some warnings failing CI that aren't your fault. I'll get those fixed, then you can rebase them back into this PR.

At a cursory glance your code looks good, but I'll look more in depth later.

edit: fixes merged, you can sync with master (there might be .lock conflicts, sorry)

Cool, thank you!

@tom-stytch
Copy link
Contributor Author

@iamwacko thanks, I imported the updated Cargo.lock and I was able to run tests and build locally. 🙏

@tom-stytch
Copy link
Contributor Author

Also, sorry @iamwacko for the formatting changes in e2e.sh, I think my editor is opinionated. Normally I would make those changes in a separate PR.

@iamwacko iamwacko self-requested a review September 25, 2024 19:23
Copy link
Collaborator

@iamwacko iamwacko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@iamwacko iamwacko merged commit fdbecd2 into shuttle-hq:master Sep 25, 2024
10 checks passed
@iamwacko
Copy link
Collaborator

Also, sorry @iamwacko for the formatting changes in e2e.sh, I think my editor is opinionated. Normally I would make those changes in a separate PR.

Imo, formatting changes in unrelated sections are fine in feature PRs. We don't really need more PR's that don't have substantive practical effects

@iamwacko
Copy link
Collaborator

If you want to add any more changes, PR's are always welcome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants