Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(store): better display for long path names #293

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Haroenv
Copy link
Collaborator

@Haroenv Haroenv commented Apr 8, 2019

Quick question: when was the last time it was deployed? I still don't see my change from #193 when I go to the online version.

Thanks!

Description

A display which works for long path names

Motivation and Context

We have a few quite long path names, for which a flat display doesnt make much sense, so I chose to go for a "vertical" display in all cases

Screenshots (if appropriate):

before:

Screenshot 2019-04-08 at 14 59 24

after:

Screenshot 2019-04-08 at 14 59 11

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the code style of this project.
  • If my change requires a change to the documentation I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I created an issue for the Pull Request

We have a few quite long path names, for which a flat display doesnt make much sense, so I chose to go for a "vertical" display in all cases

Quick question: when was the last time it was deployed? I still don't see my change from siddharthkp#193 when I go to the online version.

Thanks!
@palashmon palashmon mentioned this pull request Jul 4, 2019
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant