Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update docker ref to pull from GHCR image #301

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

bobcallaway
Copy link
Member

cached docker images have been removed from the ubuntu24.04 image (per actions/runner-images#10636) ... so when ubuntu-latest pointer moves in December, this will break our prober.

Instead of pulling from docker hub and potentially running into rate limiting, this changes to pull from a container on GHCR which hopefully minimizes external flakes

Copy link
Contributor

@haydentherapper haydentherapper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also explore using the actions cache to cache a pulled image?

@bobcallaway
Copy link
Member Author

We haven’t had good luck with actions cache for the go code we rebuild but potentially if we fixed #94 we could just reuse that?

@bobcallaway bobcallaway merged commit 84c3c7c into sigstore:main Nov 6, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants