-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add Template Constraints #183
base: master
Are you sure you want to change the base?
Conversation
@deadalnix this is obliviously correct.... |
The template parameter one was "obviously" correct as well, while in fact completely useless as some cast were missing. |
b856484
to
852feb2
Compare
852feb2
to
7e5348d
Compare
now it has a test. |
libd/src/d/semantic/dtemplate.d
Outdated
@@ -159,6 +159,26 @@ private: | |||
return false; | |||
} | |||
} | |||
|
|||
if(t.constraint) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
space
Where is the opEqual at ? You are going into the same pattern as last time: plenty of PR, that are not bad, but not great either, and eventually, almost none get merged. Attention to details is important when programming. |
75c4690
to
ef8f5ad
Compare
I added a test for templated structs |
Still no check for raw templates... |
163e3d1
to
e644d29
Compare
Still no IFTI, style doesn't match the rest of the code. At this point, I can't trust this code is test thoroughly. Also CI is failing... |
44f775e
to
5a6224e
Compare
I added a test involving ITFI, |
5a6224e
to
8ad37ee
Compare
what is blocking this ? |
9fcc9e5
to
a1ef70f
Compare
dc3ea09
to
1f71c2a
Compare
0fb9de0
to
208c449
Compare
f94baa8
to
87a9baf
Compare
cf07b66
to
39f39ba
Compare
4acd1ab
to
e854d3d
Compare
0896895
to
5a79292
Compare
previously the template constraint was just skipped.
now it is saves as part of the templateDeclaration.