Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Template Constraints #183

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

UplinkCoder
Copy link
Contributor

previously the template constraint was just skipped.
now it is saves as part of the templateDeclaration.

@UplinkCoder
Copy link
Contributor Author

@deadalnix this is obliviously correct....
and no there is no test because this only adds parsing of template constraints.
efficient handling of those is something I am working on but it is not ready yet.
please merge the parser/ast fix on it's own for now...

@deadalnix
Copy link
Contributor

The template parameter one was "obviously" correct as well, while in fact completely useless as some cast were missing.

@UplinkCoder
Copy link
Contributor Author

now it has a test.

@@ -159,6 +159,26 @@ private:
return false;
}
}

if(t.constraint) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

space

@deadalnix
Copy link
Contributor

Where is the opEqual at ? You are going into the same pattern as last time: plenty of PR, that are not bad, but not great either, and eventually, almost none get merged. Attention to details is important when programming.

@UplinkCoder UplinkCoder force-pushed the fixTemplateConstraint branch 2 times, most recently from 75c4690 to ef8f5ad Compare January 17, 2016 07:17
@UplinkCoder
Copy link
Contributor Author

I added a test for templated structs

@deadalnix
Copy link
Contributor

Still no check for raw templates...

@UplinkCoder UplinkCoder force-pushed the fixTemplateConstraint branch 2 times, most recently from 163e3d1 to e644d29 Compare January 18, 2016 13:09
@UplinkCoder UplinkCoder changed the title add Template Constraint to AST add Template Constraints Jan 18, 2016
@deadalnix
Copy link
Contributor

Still no IFTI, style doesn't match the rest of the code. At this point, I can't trust this code is test thoroughly. Also CI is failing...

@UplinkCoder UplinkCoder force-pushed the fixTemplateConstraint branch 2 times, most recently from 44f775e to 5a6224e Compare January 18, 2016 14:28
@UplinkCoder
Copy link
Contributor Author

I added a test involving ITFI,
tough without is-expressions it is kinda useless

@UplinkCoder
Copy link
Contributor Author

what is blocking this ?

@deadalnix deadalnix force-pushed the master branch 4 times, most recently from dc3ea09 to 1f71c2a Compare December 1, 2022 00:10
@deadalnix deadalnix force-pushed the master branch 2 times, most recently from 0fb9de0 to 208c449 Compare January 2, 2023 16:27
@deadalnix deadalnix force-pushed the master branch 2 times, most recently from f94baa8 to 87a9baf Compare August 23, 2023 22:14
@deadalnix deadalnix force-pushed the master branch 3 times, most recently from cf07b66 to 39f39ba Compare January 3, 2024 14:18
@deadalnix deadalnix force-pushed the master branch 2 times, most recently from 4acd1ab to e854d3d Compare June 17, 2024 21:01
@deadalnix deadalnix force-pushed the master branch 3 times, most recently from 0896895 to 5a79292 Compare October 13, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants