Fix continuous integration DCO sign-off check #765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sebastian Crane <[email protected]>
|
These instructions might be helpful for disabling the existing DCO check: https://docs.github.com/en/developers/apps/managing-github-apps/deleting-a-github-app |
goneall
approved these changes
Jul 29, 2022
There was a problem hiding this comment.
Thanks @seabass-labrax - This looks like a good alternative to the current check.
|
@goneall - is this still moving forward, or should it be closed now? |
|
@kestewart - we need to fix the DCO signoff - let's leave this open - it's marked as a draft, so I'll need to do a review if the PR to see if it is ready. Have a few higher priority SPDX items to take care of first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces to this repository the same DCO check as in the SPDX Canonical Serialisation specification repository (with some minor modifications).
Some recent pull requests have been failing the automated checks (#758 for instance). The intention of this commit is to replace the 'GitHub App' DCO check with the
dco-checkopen source Python package, which does not fail for such pull requests.After merging this pull request, the commit will need to be merged/rebased into the other branches on which checks should be run. Also, the DCO GitHub App will need to be disabled by a SPDX organisation admin who holds sufficient GitHub permissions.
Signed-off-by: Sebastian Crane <[email protected]>